This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Log the Pid after Tye application is started #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philliphoff
reviewed
Aug 11, 2021
philliphoff
approved these changes
Aug 12, 2021
|
The unit tests are flaky and fail randomly with errors that aren't related to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tooling needs the
pidof the application after it is started to match it to the applications the tooling has started and then execute operations on it (e.g. shutdown).microsoft/vscode-tye#127 is such request from tooling where
pidis required.This PR adds a log to emit the
pidafter the application has started.