Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

using the ASP.NET Core HealthChecks library for the liveness/readiness sample #523

Merged
merged 5 commits into from
Jun 12, 2020
Merged

using the ASP.NET Core HealthChecks library for the liveness/readiness sample #523

merged 5 commits into from
Jun 12, 2020

Conversation

areller
Copy link
Contributor

@areller areller commented May 31, 2020 •
edited
Loading

As discussed in #502

jkotalik
jkotalik reviewed Jun 1, 2020
View reviewed changes
docs/recipes/probes.md Outdated
.AddCheck("someReadinessCheck", new MyGenericCheck(_statusDictionary, "someReadinessCheck"), failureStatus: HealthStatus.Unhealthy, tags: new[] { "readiness" });
```

(Starting .NET 5, the HealthChecks library ships together with ASP.NET Core)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this package has been shipping since 2.2. I'm not sure if we are shipping the HealthChecks library with ASP.NET Core though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right. I saw that the HealthChecks library moved to the aspnetcore repository after .NET 5, but it has been and still part of the extensions library.

jkotalik
jkotalik approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@jkotalik jkotalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but overall looks great. I'd like to take a spin with this entire experience locally.

Again thanks for the contribution.

@davidfowl
Copy link
Member

Thanks for the doc! I think we should leave the readiness check and liveness check as fake checks that don't change as a result of an http request. It's fine in a sample but I would leave it out of the doc since it's not exactly what you would do in practice.

@areller
Copy link
Contributor Author

areller commented Jun 2, 2020

@davidfowl I removed the whole talk about the /set endpoint away from the doc, but I added it to the / endpoint of the sample service. how's that?

@jkotalik jkotalik added this to the 0.3 milestone Jun 8, 2020
@jkotalik jkotalik merged commit a7eae8f into dotnet:master Jun 12, 2020
@jkotalik
Copy link
Contributor

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotalik jkotalik jkotalik approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

@rynowak rynowak Awaiting requested review from rynowak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@areller @davidfowl @jkotalik