Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all "into CoreFX master" subscriptions to new VersionTools build task #48

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

dagood
Copy link
Member

@dagood dagood commented Aug 8, 2016

The new command looks like:

build-managed.cmd -- /t:UpdateDependencies
  /p:GitHubUser=dotnet-bot
  /p:GitHubEmail=dotnet-bot@microsoft.com
  /p:GitHubAuthToken=...
  /p:ProjectRepoOwner=dotnet
  /p:ProjectRepoName=corefx
  /p:ProjectRepoBranch=master
  /p:NotifyGitHubUsers="dotnet/corefx-contrib"

UpdateDependencies updates all corefx dependencies at the same time (to put it in the same PR) so the same command happens no matter which dependency changes. (Ripe for a refactor into multiple paths per subscription!)

When the VersionTools changes get merged into dev/api I'll need to change the subscription for that branch too.

/cc @weshaggard @eerhardt

@dagood
Copy link
Member Author

dagood commented Aug 8, 2016

Merging this in so I can kick off a build and see if it works end to end.

@dagood dagood merged commit bc8f197 into dotnet:master Aug 8, 2016
@dagood dagood deleted the versiontools-corefx-master branch August 8, 2016 22:38
@weshaggard
Copy link
Member

👍

I assume we are still planning on changing the structure of this at some other point to have a list of files to monitor instead of needing to duplicate the update commands.

@dagood
Copy link
Member Author

dagood commented Aug 8, 2016

Yep, I think it's just a matter of prioritization at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants