Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SDK build of OmniSharp the default #5176

Merged
merged 15 commits into from
May 19, 2022
Merged

Make SDK build of OmniSharp the default #5176

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8cd67f8
Make SDK build of OmniSharp the default
JoeRobich Apr 18, 2022
a5a95ca
Merge remote-tracking branch 'origin/master' into default-sdk-omnisharp
JoeRobich Apr 26, 2022
44abe7c
Merge branch 'master' into default-sdk-omnisharp
JoeRobich May 12, 2022
b5dcb45
Merge branch 'master' into default-sdk-omnisharp
JoeRobich May 17, 2022
fb85899
Do not hardcode a VSC version to use during integrationTests
JoeRobich May 17, 2022
97702a6
Do not hardcode a VSC version to use during feature tests
JoeRobich May 17, 2022
9b08cb1
Properly default useModernNet option
JoeRobich May 17, 2022
64049b6
Update Unit tests
JoeRobich May 17, 2022
c6f5b3e
Move to new testing npm package
JoeRobich May 17, 2022
c6e88e7
Fix null exception
JoeRobich May 17, 2022
737cd7e
Install NET 6 SDK in CI
JoeRobich May 18, 2022
91a863c
Revert "Do not hardcode VSC version"
JoeRobich May 18, 2022
d32e78a
Fix package.json indentation. Update .editorconfig.
JoeRobich May 18, 2022
da215dc
Revert nonbreaking spaces in package.json
JoeRobich May 18, 2022
7cc164c
Remove __metadata from package.json
JoeRobich May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix null exception
  • Loading branch information
@JoeRobich
JoeRobich committed May 17, 2022
commit c6e88e7cb7b0c112aca0742c0ca9c574de6b7af1
2 changes: 1 addition & 1 deletion src/observers/OmnisharpLoggerObserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class OmnisharpLoggerObserver extends BaseLoggerObserver {
this.logger.append(`OmniSharp server started`);
if (event.hostVersion) {
this.logger.append(` with ${event.hostIsMono ? 'Mono' : '.NET'} ${event.hostVersion}`);
if (event.hostPath.length > 0) {
if (event.hostPath?.length > 0) {
this.logger.append(` (${event.hostPath})`);
}
}
Expand Down