Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low-hanging nullable fruit #5186

Merged
merged 19 commits into from
Apr 25, 2022
Merged

Low-hanging nullable fruit #5186

merged 19 commits into from
Apr 25, 2022

Commits on Apr 24, 2022

  1. Satisfy TSLint

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    a43ea18 View commit details
    Browse the repository at this point in the history

  2. Mark isNetCoreProject as synchronous 

    Needed for a telemetry summation in extension.ts to function properly.
    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    8040603 View commit details
    Browse the repository at this point in the history

  3. Remove Range support from createRequest 

    No consumer uses Range.
    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    eb8e2a8 View commit details
    Browse the repository at this point in the history

  4. Nullability fixes for requestQueue

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    b4b0033 View commit details
    Browse the repository at this point in the history

  5. Mark all findNet* functions as nullable

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    ff51b3b View commit details
    Browse the repository at this point in the history

  6. Nullability fixes for options 

    * Change optional properties to nullable to better reflect their status
* Simplify nullable config retrieval
* Simplify readUseGlobalMonoOptions
    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    6b6a2e4 View commit details
    Browse the repository at this point in the history

  7. Explicitly check omnisharpPath for undefinedness

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    9b216d2 View commit details
    Browse the repository at this point in the history

  8. Always return bool in DownloadAndInstallOmnisharp

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    e6a3014 View commit details
    Browse the repository at this point in the history

  9. Assert non-null in launcher.ts

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    7a74761 View commit details
    Browse the repository at this point in the history

  10. Guard against possible undefined in LanguageMiddlewareFeature

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    6eea46b View commit details
    Browse the repository at this point in the history

  11. Change fileToOpen to a nullable type

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    cf029c6 View commit details
    Browse the repository at this point in the history

  12. Remove unused buildPromiseChain

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    592cd72 View commit details
    Browse the repository at this point in the history

  13. Some low-hanging nullability fixes in server

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    6ff620f View commit details
    Browse the repository at this point in the history

  14. Make localDisposables a nullable type in extension

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    36ddb31 View commit details
    Browse the repository at this point in the history

  15. Mark properties in OmnisharpLaunch as nullable

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    ca1e483 View commit details
    Browse the repository at this point in the history

  16. Update options.path-related unit tests

    @50Wliu
    50Wliu committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    3f4edeb View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Test for empty omnisharp.path

    @50Wliu
    50Wliu committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    f665582 View commit details
    Browse the repository at this point in the history

  2. Try not setting defaults for string options

    @50Wliu
    50Wliu committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    43bacd3 View commit details
    Browse the repository at this point in the history

  3. Default string settings to the empty string

    @50Wliu
    50Wliu committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    6576c95 View commit details
    Browse the repository at this point in the history