Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser WBT on Chrome: avoid "no such window: target window already closed" #1265

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Browser WBT on Chrome: avoid "no such window: target window already closed" #1265

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
386cff5
Avoid "no such window: target window already closed" exception.
ilonatommy Sep 10, 2024
a4021de
Give the browser 1 sec before re-checking if `driverService` is finis…
ilonatommy Sep 10, 2024
0d8731a
Feedback, allow delay cancellation.
ilonatommy Sep 10, 2024
62b27a1
Remove whitespaces.
ilonatommy Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give the browser 1 sec before re-checking if driverService is finis… 
…hed.
  • Loading branch information
@ilonatommy
ilonatommy committed Sep 10, 2024
commit a4021dec82f3697fc46d41131cf6251dd0ebf4cd
1 change: 1 addition & 0 deletions src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)
driver.SwitchTo().Window(lastWindowHandle);
}
}
System.Threading.Thread.Sleep(1000);
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved
if (driverService.IsRunning)
{
if (!cts.IsCancellationRequested && driver.WindowHandles.Count != 0)
Expand Down
Loading