Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: govern host and port #891

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: govern host and port #891

merged 1 commit into from
May 24, 2023

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented May 24, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live May 24, 2023 08:24 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #891 (3d28943) into master (65c9e99) will increase coverage by 19.52%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master     #891       +/-   ##
===========================================
+ Coverage   33.42%   52.94%   +19.52%     
===========================================
  Files         160      202       +42     
  Lines        8450    11339     +2889     
===========================================
+ Hits         2824     6003     +3179     
+ Misses       5393     4883      -510     
- Partials      233      453      +220     
Impacted Files Coverage Δ
pkg/server/governor/config.go 39.39% <50.00%> (+39.39%) ⬆️

... and 94 files with indirect coverage changes

@sysulq sysulq merged commit 758cdaa into master May 24, 2023
@sysulq sysulq deleted the fix/govern branch July 11, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants