Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

release/3.0.13 #66

Merged
merged 5 commits into from
Jul 28, 2023
Merged

release/3.0.13 #66

merged 5 commits into from
Jul 28, 2023

Conversation

mayurngondhkar
Copy link
Contributor

@mayurngondhkar mayurngondhkar commented Jul 27, 2023 •
edited
Loading

@mayurngondhkar mayurngondhkar self-assigned this Jul 27, 2023
@mayurngondhkar
Copy link
Contributor Author

Have to fix up the build and build suggest tests failing

@MdNadimHossain
Copy link
Contributor

ci build failed

anthony-malkoun
anthony-malkoun suggested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-rolled patch not applying?

@MdNadimHossain
Copy link
Contributor

They did a release recently, which broke the 2nd patch as well. I have re-rolled the 2nd patch and updated the merge request. The build should pass now
@mayurngondhkar

@mayurngondhkar
Copy link
Contributor Author

You beat me to it @MdNadimHossain by 6 mins. I had the rerolled patch ready.

@mayurngondhkar mayurngondhkar merged commit 3511e71 into master Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MdNadimHossain MdNadimHossain MdNadimHossain approved these changes

@krakerag krakerag Awaiting requested review from krakerag

@yeniatencio yeniatencio Awaiting requested review from yeniatencio

@anthony-malkoun anthony-malkoun Awaiting requested review from anthony-malkoun

Assignees

@mayurngondhkar mayurngondhkar

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayurngondhkar @MdNadimHossain @anthony-malkoun @waitingallday