Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

[SDPA-2005] Refactored ES Connector service alts. #15

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented Apr 15, 2019

Alters the ES Connector Index Factory service to append the hash to index name.

Project implementation: dpc-sdp/content-vic-gov-au#544

@GROwen GROwen self-assigned this Apr 15, 2019
@anthony-malkoun
Copy link
Contributor

Hey @GROwen I'm confused what this is doing. Is there meant to be more to this change?

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, if this loads in the correct methods then it is the correct way to do it. Please add the links to the relevant blog posts for my information, but Approved.

@GROwen
Copy link
Contributor Author

GROwen commented Apr 16, 2019

As discussed, if this loads in the correct methods then it is the correct way to do it. Please add the links to the relevant blog posts for my information, but Approved.

How to override a Drupal 8 service
https://www.previousnext.com.au/blog/overriding-services-drupal-8-advanced-cases
That article provides two options based on requirements.
Firstly Tim Milwood's static example which works when you don’t need to change arguments or conditionally add the alter or do anything dynamically
The PN article progresses into a more detailed example of the replacement of a service.

@GROwen GROwen merged commit 9c97390 into master Apr 16, 2019
@GROwen GROwen deleted the hotfix/1.0.2 branch April 16, 2019 04:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants