Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

elasticsearch_connector module fixes the issue #26

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

vincent-gao
Copy link
Contributor

@vincent-gao vincent-gao commented Oct 27, 2020

  1. https://www.drupal.org/project/elasticsearch_connector/issues/3166369

There was an issue with nodespark/des-connector library. It has been fixed so now it should be OK.

our upstream has been fixed the missed dependency, so we don't need the composer alias.

  1. https://www.drupal.org/project/elasticsearch_connector/issues/3010955
    the PR above is merged, so we don't need the patch.

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anthony-malkoun
Copy link
Contributor

Although, builds are broken @vincent-gao?

@vincent-gao
Copy link
Contributor Author

Although, builds are broken @vincent-gao?

Hi @anthony-malkoun , I have added another commit to remove the patch, as it has been merged in upstream.

@vincent-gao
Copy link
Contributor Author

greens!

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green!

@vincent-gao vincent-gao merged commit f66a288 into develop Oct 27, 2020
@vincent-gao vincent-gao deleted the feature/des-connector-issue branch October 27, 2020 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants