This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[SDPAP-6684] Verify items in search index drush command #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdNadimHossain
commented
Oct 14, 2022
composer.json
Outdated
| @@ -6,12 +6,19 @@ | |||
| "require": { | |||
| "drupal/search_api": "^1.11", | |||
| "drupal/elasticsearch_connector": "^7.0", | |||
| "dpc-sdp/tide_core": "^3.0.0" | |||
| "dpc-sdp/tide_core": "dev-feature/SRM-512_update_drupal_to_9.4" | |||
There was a problem hiding this comment.
will be reverted before merging
MdNadimHossain
commented
Oct 14, 2022
dev-tools.sh
Outdated
| @@ -33,6 +33,6 @@ | |||
| # stable version. | |||
| # | |||
| # Uncomment and set the Dev-Tools's commit value and commit this change. | |||
| # export GH_COMMIT=COMMIT_SHA | |||
| export GH_COMMIT=960eba39ed9543b17654dbd5e06f3a2ab2b1fb4b | |||
There was a problem hiding this comment.
will be reverted before merging
MdNadimHossain
requested review from
vincent-gao,
anthony-malkoun,
edyuenyw,
mayurngondhkar and
yeniatencio
vincent-gao
reviewed
Oct 18, 2022
src/Commands/TideSearchCommands.php
Outdated
| /** | ||
| * Helper to convert node ids. | ||
| */ | ||
| public static function convertToNodeIds($item) { |
There was a problem hiding this comment.
hey @MdNadimHossain ,
I think you don't need the function convertToNodeIds.
the $results is an object that implements ResultInterface, so I think you can get the actual result by using $results->getExtraData('elasticsearch_response') or $results->getAllExtraData() , then loop through to get nid from the result.
|
Thanks @vincent-gao for pointing out that. |
vincent-gao
approved these changes
Nov 10, 2022
MdNadimHossain
deleted the
feature/SDPAP-6684-verify-items-in-search-index-drush-command
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://digital-vic.atlassian.net/browse/SDPAP-6684
Changes
Testing PR
https://nginx-php.pr-142.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au
Test steps