Fix bug where nested item is not removed.

dpmcmlxxvi · Apr 15, 2018 · 379f177 · 379f177
1 parent 71634af
commit 379f177
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 19 deletions.
diff --git a/dist/olexp.css b/dist/olexp.css
diff --git a/dist/olexp.js b/dist/olexp.js
@@ -1,4 +1,4 @@
-/* olexp 0.3.0 (c) Daniel Pulido <dpmcmlxxvi@gmail.com> */
+/* olexp 0.3.1 (c) Daniel Pulido <dpmcmlxxvi@gmail.com> */
 
 /*globals $, ol, olexp, w2ui, window */
 /*jslint vars: true */
@@ -4472,12 +4472,12 @@ window.olexp.manager = window.olexp.manager || {};
         // --------------------------------------------------
         var me = this;
         var itemRemoved = false;
-        this.items.forEach(function (item) {
+        this.items.forEach(function (itemChild) {
             if (itemRemoved) {
                 return;
             }
-            if (item.type === olexp.item.Type.GROUP) {
-                if (me.managers[item.id].remove(item)) {
+            if (itemChild.type === olexp.item.Type.GROUP) {
+                if (me.managers[itemChild.id].remove(item)) {
                     itemRemoved = true;
                     return;
                 }
@@ -4504,12 +4504,12 @@ window.olexp.manager = window.olexp.manager || {};
         // --------------------------------------------------
         var me = this;
         var itemRemoved = null;
-        this.items.forEach(function (item) {
+        this.items.forEach(function (itemChild) {
             if (itemRemoved !== null) {
                 return;
             }
-            if (item.type === olexp.item.Type.GROUP) {
-                var layerChild = me.managers[item.id].removeFromMap(item);
+            if (itemChild.type === olexp.item.Type.GROUP) {
+                var layerChild = me.managers[itemChild.id].removeFromMap(item);
                 if (layerChild !== null) {
                     itemRemoved = layerChild;
                     return;

diff --git a/dist/olexp.min.js b/dist/olexp.min.js
diff --git a/dist/olexp.sa.min.css b/dist/olexp.sa.min.css
diff --git a/dist/olexp.sa.min.js b/dist/olexp.sa.min.js
diff --git a/src/js/manager.js b/src/js/manager.js
@@ -1042,12 +1042,12 @@ window.olexp.manager = window.olexp.manager || {};
         // --------------------------------------------------
         var me = this;
         var itemRemoved = false;
-        this.items.forEach(function (item) {
+        this.items.forEach(function (itemChild) {
             if (itemRemoved) {
                 return;
             }
-            if (item.type === olexp.item.Type.GROUP) {
-                if (me.managers[item.id].remove(item)) {
+            if (itemChild.type === olexp.item.Type.GROUP) {
+                if (me.managers[itemChild.id].remove(item)) {
                     itemRemoved = true;
                     return;
                 }
@@ -1074,12 +1074,12 @@ window.olexp.manager = window.olexp.manager || {};
         // --------------------------------------------------
         var me = this;
         var itemRemoved = null;
-        this.items.forEach(function (item) {
+        this.items.forEach(function (itemChild) {
             if (itemRemoved !== null) {
                 return;
             }
-            if (item.type === olexp.item.Type.GROUP) {
-                var layerChild = me.managers[item.id].removeFromMap(item);
+            if (itemChild.type === olexp.item.Type.GROUP) {
+                var layerChild = me.managers[itemChild.id].removeFromMap(item);
                 if (layerChild !== null) {
                     itemRemoved = layerChild;
                     return;