Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): force string sets style #2448

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jun 7, 2024

如何测试?
输入'1 得到强制字符串,再设置样式(比如字体颜色),检验是否强制字符串消失

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir force-pushed the dushusir/force-string-style branch from b8158bf to 5edd44e Compare June 7, 2024 08:19
@Dushusir Dushusir marked this pull request as ready for review June 7, 2024 08:19
@univer-bot
Copy link

univer-bot bot commented Jun 7, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(sheet): force string sets style

Title: fix(sheet): force string sets style


如何测试?
输入'1 得到强制字符串,再设置样式(比如字体颜色),检验是否强制字符串消失

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.17%. Comparing base (9205148) to head (82fa9a6).
Report is 2 commits behind head on dev.

Files Patch % Lines
...er-link-ui/src/controllers/set-range.controller.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2448      +/-   ##
==========================================
- Coverage   27.17%   27.17%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       83494    83499       +5     
  Branches    17363    17365       +2     
==========================================
+ Hits        22693    22694       +1     
- Misses      60801    60805       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7
Copy link

@Dushusir 添加链接后绿标消失
image

@univer-bot
Copy link

univer-bot bot commented Jun 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir The green mark disappears after adding the link
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 14, 2024
@Dushusir Dushusir force-pushed the dushusir/force-string-style branch from 5edd44e to ce30d39 Compare June 15, 2024 09:33
@Dushusir Dushusir requested a review from jikkai as a code owner June 15, 2024 10:32
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:rejected labels Jun 15, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 17, 2024
@zhaolixin7 zhaolixin7 added the qa:untested This PR is ready to be tested label Jun 17, 2024
@univer-bot univer-bot bot removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 17, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 17, 2024
@Dushusir Dushusir merged commit 17130d1 into dev Jun 17, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/force-string-style branch June 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants