Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): button class priority #2485

Merged
merged 2 commits into from
Jun 15, 2024
Merged

fix(sheet): button class priority #2485

merged 2 commits into from
Jun 15, 2024

Conversation

siam-ese
Copy link
Contributor

close #1116

Other styling issues have been fixed, with the exception of this button styling issue.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 12, 2024
@siam-ese siam-ese requested a review from wzhudev June 12, 2024 06:59
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.15%. Comparing base (74d185a) to head (7e22880).
Report is 26 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2485      +/-   ##
==========================================
+ Coverage   27.10%   27.15%   +0.04%     
==========================================
  Files        1653     1654       +1     
  Lines       83306    83330      +24     
  Branches    17256    17258       +2     
==========================================
+ Hits        22584    22626      +42     
+ Misses      60722    60704      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 15, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 15, 2024
@siam-ese siam-ese merged commit 9205148 into dev Jun 15, 2024
9 checks passed
@siam-ese siam-ese deleted the fix/btn-style branch June 15, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants