test(sheet): active sheet test

packages/sheets-filter-ui/src/controllers/sheets-filter-render.controller.ts

@@ -83,7 +83,7 @@ export class SheetsFilterRenderController extends RxDisposable implements IRende
                     if (!skeletonParams) return of(null);
 
                     const { unit: workbook, unitId } = this._context;
-                    const worksheetId = workbook.getActiveSheet().getSheetId();
+                    const worksheetId = workbook.getActiveSheet()?.getSheetId() || '';
                     const filterModel = this._sheetsFilterService.getFilterModel(unitId, worksheetId) ?? undefined;
                     const getParams = (): ISheetsFilterRenderParams => ({
                         unitId,

packages/sheets-filter/src/models/__tests__/filter-interceptor.spec.ts

@@ -15,8 +15,8 @@
  */
 
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import type { IWorkbookData, LocaleType } from '@univerjs/core';
-import { Direction, ICommandService, Plugin, RANGE_TYPE, Univer, UniverInstanceType } from '@univerjs/core';
+import type { IWorkbookData, LocaleType, Workbook } from '@univerjs/core';
+import { Direction, ICommandService, IUniverInstanceService, Plugin, RANGE_TYPE, Univer, UniverInstanceType } from '@univerjs/core';
 import type { Dependency } from '@wendellhu/redi';
 import { Inject, Injector } from '@wendellhu/redi';
 
@@ -37,6 +37,12 @@ describe('Test "Filter Interceptor"', () => {
         get = testBed.get;
         sheetsFilterService = testBed.sheetsFilterService;
         commandService = testBed.commandService;
+        univer.__getInjector();
+
+        // active sheet
+        const currentService = get(IUniverInstanceService);
+        const workbook = currentService.getCurrentUnitForType<Workbook>(UniverInstanceType.UNIVER_SHEET)!;
+        workbook.ensureActiveSheet();
     });
 
     afterEach(() => {

packages/sheets-filter/src/models/__tests__/filter-model.spec.ts

@@ -131,7 +131,7 @@ describe('Test filter model and related utils', () => {
             filterColumn = new FilterColumn(
                 'test',
                 'sheet1',
-                get(IUniverInstanceService).getCurrentUnitForType<Workbook>(UniverInstanceType.UNIVER_SHEET)!.getActiveSheet()!,
+                get(IUniverInstanceService).getCurrentUnitForType<Workbook>(UniverInstanceType.UNIVER_SHEET)!.ensureActiveSheet(),
                 { colId: 0, customFilters: { customFilters: [{ operator: CustomFilterOperator.LESS_THAN, val: 123 }] } },
                 { getAlreadyFilteredOutRows() { return new Set(); } }
             );

packages/sheets-find-replace/src/controllers/__tests__/utils.spec.ts

@@ -210,7 +210,7 @@ describe('test "hitCell" method', () => {
     beforeEach(() => {
         const testBed = createTestBed();
         univer = testBed.univer;
-        worksheet = testBed.sheet.getActiveSheet();
+        worksheet = testBed.sheet.getActiveSheet()!;
     });
 
     afterEach(() => {

packages/sheets-find-replace/src/controllers/sheet-find-replace.controller.ts

@@ -217,6 +217,10 @@ export class SheetFindModel extends FindModel {
                 )
                 .subscribe(() => {
                     const activeSheet = this._workbook.getActiveSheet();
+                    if (!activeSheet) {
+                        return;
+                    }
+
                     const activeSheetId = activeSheet.getSheetId();
                     if (!this._matchesByWorksheet.has(activeSheetId)) {
                         return;
@@ -280,6 +284,7 @@ export class SheetFindModel extends FindModel {
 
         const checkShouldFindInSelections = (): boolean => {
             const currentWorksheet = this._workbook.getActiveSheet();
+            if (!currentWorksheet) return false;
             const currentSelections = this._selectionManagerService.getSelections();
             const shouldFindInSelections = currentSelections?.some((selection) => !isSelectionSingleCell(selection, currentWorksheet)) ?? false;
             return shouldFindInSelections;
@@ -291,6 +296,8 @@ export class SheetFindModel extends FindModel {
 
         const performFindInWorksheet = (): IFindComplete => {
             const currentWorksheet = this._workbook.getActiveSheet();
+            if (!currentWorksheet) return { results: [] };
+
             const lastMatch = this.currentMatch; // temporarily store the last match to restore the position after the model changes
 
             findBySelections = checkShouldFindInSelections();
@@ -476,6 +483,10 @@ export class SheetFindModel extends FindModel {
         const searchBackgroundColor = this._themeService.getCurrentTheme().gold400;
         const color = new ColorKit(searchBackgroundColor).toRgb();
         const worksheet = this._workbook.getActiveSheet();
+        if (!worksheet) {
+            return;
+        }
+
         const activeSheetId = worksheet.getSheetId();
         const highlightShapes = matches.filter((match) => match.range.subUnitId === activeSheetId).map((find, index) => {
             const { startColumn, startRow, endColumn, endRow } = find.range.range;
@@ -533,7 +544,7 @@ export class SheetFindModel extends FindModel {
 
     private _focusMatch(match: ISheetCellMatch): void {
         const subUnitId = match.range.subUnitId;
-        if (subUnitId !== this._workbook.getActiveSheet().getSheetId()) {
+        if (subUnitId !== this._workbook.getActiveSheet()?.getSheetId()) {
             this._commandService.syncExecuteCommand(SetWorksheetActivateCommand.id,
                 { unitId: this._workbook.getUnitId(), subUnitId } as ISetWorksheetActivateCommandParams,
                 { fromFindReplace: true }
@@ -585,7 +596,7 @@ export class SheetFindModel extends FindModel {
             }
 
             if (!noFocus) this._focusMatch(match);
-            if (this._workbook.getActiveSheet().getSheetId() === match.range.subUnitId) {
+            if (this._workbook.getActiveSheet()?.getSheetId() === match.range.subUnitId) {
                 this._updateCurrentHighlightShape(this._activeHighlightIndex);
             }
 
@@ -618,7 +629,7 @@ export class SheetFindModel extends FindModel {
             }
 
             if (!noFocus) this._focusMatch(match);
-            if (this._workbook.getActiveSheet().getSheetId() === match.range.subUnitId) {
+            if (this._workbook.getActiveSheet()?.getSheetId() === match.range.subUnitId) {
                 this._updateCurrentHighlightShape(this._activeHighlightIndex);
             }
 
@@ -660,7 +671,11 @@ export class SheetFindModel extends FindModel {
             return this._findPreviousMatchByRange(this._matches, selections[0].range);
         }
 
-        const currentSheetId = this._workbook.getActiveSheet().getSheetId();
+        const currentSheetId = this._workbook.getActiveSheet()?.getSheetId();
+        if (!currentSheetId) {
+            return null;
+        }
+
         const worksheetThatHasMatch = this._findPreviousWorksheetThatHasAMatch(currentSheetId, loop);
         if (!worksheetThatHasMatch) {
             return null;
@@ -699,7 +714,11 @@ export class SheetFindModel extends FindModel {
             return this._findNextMatchByRange(this._matches, selections[0].range, stayIfOnMatch);
         }
 
-        const currentSheetId = this._workbook.getActiveSheet().getSheetId();
+        const currentSheetId = this._workbook.getActiveSheet()?.getSheetId();
+        if (!currentSheetId) {
+            return null;
+        }
+
         const worksheetThatHasMatch = this._findNextWorksheetThatHasAMatch(currentSheetId, loop);
         if (!worksheetThatHasMatch) {
             return null;

packages/sheets-hyper-link-ui/src/controllers/remove-sheet.controller.ts

@@ -43,7 +43,10 @@ export class SheetsHyperLinkRemoveSheetController extends Disposable {
                             return { redos: [], undos: [] };
                         }
                         const unitId = workbook.getUnitId();
-                        const subUnitId = params.subUnitId || workbook.getActiveSheet().getSheetId();
+                        const subUnitId = params.subUnitId || workbook.getActiveSheet()?.getSheetId();
+                        if (!subUnitId) {
+                            return { redos: [], undos: [] };
+                        }
                         const links = this._hyperLinkModel.getSubUnit(unitId, subUnitId);
 
                         const redos = links.map((link) => ({

packages/sheets-hyper-link-ui/src/services/resolver.service.ts

@@ -239,6 +239,9 @@ export class SheetsHyperLinkResolverService {
             return false;
         }
         const worksheet = workbook.getActiveSheet();
+        if (!worksheet) {
+            return false;
+        }
 
         if (worksheet.getSheetId() === subUnitId) {
             return worksheet;

packages/sheets-hyper-link-ui/src/views/CellLinkEdit/index.tsx

@@ -177,7 +177,7 @@ export const CellLinkEdit = () => {
             return;
         }
         if (!range.sheetName) {
-            range.sheetName = workbook.getActiveSheet().getName();
+            range.sheetName = workbook.getActiveSheet()?.getName() || '';
         }
         const newPayload = serializeRangeToRefString(range);
         setPayload(newPayload);

packages/sheets-numfmt/src/controllers/__tests__/editor.controller.spec.ts

@@ -54,7 +54,7 @@ describe('test editor', () => {
         testBed.get(NumfmtEditorController);
         testBed.get(SheetsNumfmtCellContentController);
         workbook = univerInstanceService.getCurrentUnitForType<Workbook>(UniverInstanceType.UNIVER_SHEET)!;
-        worksheet = workbook.getActiveSheet()!;
+        worksheet = workbook.ensureActiveSheet();
     });
 
     it('before edit with currency', () => {