Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): remove non-existent formula ids #2531

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jun 15, 2024

close #654
close #656
close #659
close #693

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 27.19%. Comparing base (f59ab40) to head (eebac4e).
Report is 21 commits behind head on dev.

Files Patch % Lines
packages/sheets-formula/src/formula-ui-plugin.ts 0.00% 7 Missing ⚠️
...src/controllers/formula-alert-render.controller.ts 0.00% 4 Missing ⚠️
...gine-formula/src/functions/lookup/address/index.ts 93.02% 3 Missing ⚠️
...es/engine-formula/src/models/formula-data.model.ts 0.00% 2 Missing ⚠️
...la/src/views/prompt/help-function/HelpFunction.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2531      +/-   ##
==========================================
+ Coverage   27.16%   27.19%   +0.02%     
==========================================
  Files        1653     1653              
  Lines       83684    83734      +50     
  Branches    17421    17442      +21     
==========================================
+ Hits        22736    22774      +38     
- Misses      60948    60960      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review June 17, 2024 13:15
@Dushusir Dushusir requested a review from DR-Univer as a code owner June 17, 2024 13:15
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 17, 2024
@zhaolixin7 zhaolixin7 added qa:rejected qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jun 21, 2024
@univer-bot univer-bot bot removed the qa:rejected label Jun 21, 2024
@dream-num dream-num deleted a comment from univer-bot bot Jun 21, 2024
@Dushusir Dushusir merged commit 656c337 into dev Jun 21, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs0617 branch June 21, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants