Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ubuntu version in GHA to 18.04 #457

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

AshesITR
Copy link
Contributor

Fixes #456

@pvictor
Copy link
Member

pvictor commented Dec 21, 2021

Thanks, indeed the action yaml is quite old.
What doyou think to use the last template https://github.com/r-lib/actions/blob/v2/examples/check-standard.yaml ?
Apparently version numbers are not hard written

Victor

@AshesITR
Copy link
Contributor Author

The difference is that ubuntu-latest will be 20.04 instead of 18.04.
18.04 is older than 20.04, so using 18.04 should better ensure backward compatibility.
But I'm not sure this is much of a concern for shinyWidgets since it doesn't use any system libraries AFAIK.

Let me know if I should change

@pvictor
Copy link
Member

pvictor commented Jan 6, 2022

I think ubuntu-latest is sufficient if it's okay for you

and latest usethis actions template
@AshesITR
Copy link
Contributor Author

AshesITR commented Jan 6, 2022

Of course. I've also upgraded the steps to the latest usethis template while at it.

@pvictor pvictor merged commit 324c5f6 into dreamRs:master Jan 7, 2022
@pvictor
Copy link
Member

pvictor commented Jan 7, 2022

Thank you @AshesITR ! Really appreciate your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 16.04 used in R CMD check workflow
2 participants