Extend and refactor Scene class #2384
Conversation
- add missing hue api fields to class - update database with new fields - refactor everything to make use of the new class (cherry picked from commit faeadde)
|
Hey, thanks for the PR, overall it looks good and feels way cleaner compared to the former implementation. Due the amount of changes I won't merge it for the 2.05.73 since we need more testing with various lights and brands. So hopefully it will be added in 2.05.74. |
|
Thanks for the review. Ok, that’s fine, I appreciate a bit more testing being done first. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I would really like this to be merged, I started this work over a year ago. What can I do to help? Could perhaps someone else review and test? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@KodeCR added backlog label so the bot stops bothering you. |
|
@KodeCR I'm afraid I won't be much of a help here since I don't use any scenes at all. However, I think it would be a pitty if there are good improvements and we potentially give them away... |
|
I need these extra attributes for the next steps with Hue Essentials on a Phoscon bridge. |
This is mostly the second commit from #1471 so it can be reviewed and merged in stages, cherry-picked onto the current master. This:
This PR should not result in any functional changes to the deCONZ api or behaviour. The only change visible on the api side is that the additional fields are returned when retrieving lightstates for a scene. All previous fields should also still be included.