Hue dimmer, Hue smart button, Lutron Aurora, innr RC 110, icasa Remote, Xiaomi B1 curtain motor

[ebaauw]

Improve handling of:

• Hue dimmer switch,
• Hue smart button (Philips Hue Smart Button - Support Request #2077),
• Lutron Aurora FoH dimmer switch (Support for Lutron Aurora (Friends of Hue dimmer)  #2305),
• innr RC 110 (Support for Innr Remote RC 110? #635),
• icasa Remote (Various enhancements #1978),
• Xiaomi B1 curtain motor ([Request Device Support] Aqara Curtain motor B1 #1654).

Details:

• Changed configuration of attribute reporting for the battery to match the Hue bridge.
• No longer get the group identifiers from the ZLL Commissioning cluster. Bluntly creating a group and binding the client clusters to it (as for ZigBee 3.0 devices) seems to work just fine for the Hue dimmer switch and the Hue button. The Aurora doesn't support the get group identifiers command.
• Expose innr RC 110 and icasa Remote as single ZHASwitch /sensors resource, with multiple (7 and 4) group IDs in config.group, see Switches with client clusters on multiple endpoints #2541.
• Added the switch endpoint to the uniqueid of the associated /groups resource (for RC 110 and icasa remote).
• Handle config.group containing list of group IDs.
• Refactored setting the state attributes of Window covering "lights" and of Warning device "lights", also in preparation of Input needed: Refactor logic setting light state #2475.
• Removed dead code.

Tested the pairing of the switches extensively, both on RaspBee and on ConBee II.

Tested the setting of "light" state for lights, Heiman siren, and old model Xiaomi curtain controller (using Window Covering cluster as well as Analog Output cluster). I don't have any other Window covering devices to test, nor any other Warning device devices (notably fire/smoke sensors that expose IAS WD cluster).

Open issues:

• We still need to figure out how to activate the 0xFC00 cluster on the Aurora.
• The Aurora seems to be fixed on the group it picked on reset (0xF105 (61701) in my case), and doesn't change this when binding the client clusters.
• There's still some code in database.cpp that might not be needed, but I left it in as a safety net:
  

  deconz-rest-plugin/database.cpp

  Lines 3277 to 3310 in 15ff6d3

  	if (sensor.modelId().startsWith(QLatin1String("RWL02"))) // Hue dimmer switch
  	{
  	clusterId = VENDOR_CLUSTER_ID;
  	endpoint = 2;
  	if (!sensor.fingerPrint().hasInCluster(POWER_CONFIGURATION_CLUSTER_ID))
  	{
  	sensor.fingerPrint().inClusters.push_back(POWER_CONFIGURATION_CLUSTER_ID);
  	sensor.setNeedSaveDatabase(true);
  	}
  	if (!sensor.fingerPrint().hasInCluster(VENDOR_CLUSTER_ID)) // for realtime button feedback
  	{
  	sensor.fingerPrint().inClusters.push_back(VENDOR_CLUSTER_ID);
  	sensor.setNeedSaveDatabase(true);
  	}
  	}
  	else if (sensor.modelId().startsWith(QLatin1String("ROM00"))) // Hue smart button
  	{
  	clusterId = VENDOR_CLUSTER_ID;
  	endpoint = 1;
  	if (!sensor.fingerPrint().hasInCluster(POWER_CONFIGURATION_CLUSTER_ID))
  	{
  	sensor.fingerPrint().inClusters.push_back(POWER_CONFIGURATION_CLUSTER_ID);
  	sensor.setNeedSaveDatabase(true);
  	}
  	if (!sensor.fingerPrint().hasInCluster(VENDOR_CLUSTER_ID)) // for realtime button feedback
  	{
  	sensor.fingerPrint().inClusters.push_back(VENDOR_CLUSTER_ID);
  	sensor.setNeedSaveDatabase(true);
  	}
  	}

• There's still some code in DeRestPluginPrivate::checkSensorsGroup() in bindings.cpp that doesn't handle multiple group IDs in config.group. I don't know how to fix that; I'm simply not calling this method for the innr nor the icasa.
• taskToLocalData() only handles light tasks.
• Still no support for groups containing Window covering or Warning device "lights".

[manup]

Awesome stuff :) hope I got the merge conflicts between this PR and the one from @SwoopX right.

[SwoopX]

😓

[ebaauw]

Which files had conflicts?

[SwoopX]

Added two further devices to rest_lights mimicing a smoke sensor, for the siren.

Still feel like an idiot skrewing up the merge lately...

Edit:
Nope, the change for rest_lights.cpp got missing. I'll raise another quick PR

[manup]

Which files had conflicts?

See merge commit: c26cd77

Still feel like an idiot skrewing up the merge lately...

No worries merging is inevitable when working parallel :)
I use Meld three-way merge which is very handy for these things but if code overlap too closely it can be a bit tricky.

[SwoopX]

Yeah.

Btw, I can confirm the siren is still functional on my Develco smoke sensor. Nice job!