Add no_sign_request for S3Client #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
========================================
+ Coverage 93.9% 94.1% +0.1%
========================================
Files 21 21
Lines 1179 1183 +4
========================================
+ Hits 1108 1114 +6
+ Misses 71 69 -2
|
jayqi
requested changes
Sep 7, 2021
Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com>
jayqi
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 requires explicitly not signing requests if users want anonymous access. To access a public bucket without any credentials configured, you need to instantiate a client that will not sign requests.
This PR adds a
no_sign_requestkwarg toS3Clientthat mimics the way a user might pass--no-sign-requestwith the AWS CLI to access public assets anonymously.Closes #38