LOCAL: Pull requests list Speed up non recursive list_dir for google cloud storage #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local branch for running live tests on #318.
The non-recursive implementation of list_dir for google cloud was slow.
The issue was already stated in the code that we just filtered out the top-level files and dirs out of al the blobs.
This is fixed by setting the delimiter='/' when listing a directory non-recursive.
Perf results
Before
After