Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 errors #359

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Fix flake8 errors #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6723770
Fix flake8 errors
jayqi Jul 31, 2023
e1c6377
Fix wrong comparison
jayqi Jul 31, 2023
8f5ed60
Bump codecov action version; add codecov token
jayqi Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ jobs:

- name: Upload coverage to codecov
if: matrix.os == 'ubuntu-latest'
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage.xml
fail_ci_if_error: true

Expand Down
2 changes: 1 addition & 1 deletion cloudpathlib/cloudpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ def _patched_close_empty_cache(*args, **kwargs):
return buffer

def replace(self, target: Self) -> Self:
if type(self) != type(target):
if type(self) is not type(target):
raise TypeError(
f"The target based to rename must be an instantiated class of type: {type(self)}"
)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_interface(cloud_class, local_class):
cloud_attr = getattr(cloud_class, attr_name)
local_attr = getattr(local_class, attr_name)

assert type(cloud_attr) == type(local_attr)
assert type(cloud_attr) is type(local_attr)
if callable(cloud_attr):
assert signature(cloud_attr).parameters == signature(local_attr).parameters

Expand Down
Loading