Change LocalClient to not explicitly store default storage directory #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayqi
commented
Aug 22, 2024
| assert not p1.exists() | ||
| assert not p2.exists() |
There was a problem hiding this comment.
This test had failed with my new implementation, but I think the old behavior is not desirable. In the old version of this test, we reset the storage directory before instantiating p2 and writing out p1, which means p2 uses a new default local storage but p1 still uses the old default local storage.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 415-glob-local #462 +/- ##
================================================
+ Coverage 93.6% 93.8% +0.1%
================================================
Files 23 23
Lines 1661 1664 +3
================================================
+ Hits 1556 1562 +6
+ Misses 105 102 -3
|
jayqi
added a commit
that referenced
this pull request
Aug 22, 2024
…nts, reset default storage work on default client (#436) * update glob behavior and test * Typing and changelog * no override * Self typing import * Simpler fix * Fix 414 * message for 414 * Change reset path for default * Fix linting * More waiting styles * Change LocalClient to not explicitly store default storage directory (#462) * Change LocalClient to not explicitly store default storage directory * Remove extraneous file --------- Co-authored-by: Jay Qi <jayqi@users.noreply.github.com> --------- Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com> Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed alternative fix for #414. This PR is into the branch for #436.
This changes the way that
LocalClientstores and accesses what the local storage directory should be. In the default case where no value forlocal_storage_diris provided, accessing local storage will call the class methodget_default_storage_dirto locate local storage.This means that calling
reset_default_storage_dirwill instantly reset the local storage for all clients that are using the default storage, not just future new ones that are created, and not with a special case for the default client.This feels like a more intuitive fix to me than having the special case for the default client. This means that calling
reset_default_storage_dirwill have the same effect as deleting all of the files inside the directory, in the sense that all instantiated clients using that storage directory get affected.