Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To be honest I disagree with the way we do sanitizing here and would … #1098

Closed
wants to merge 1 commit into from
Closed

To be honest I disagree with the way we do sanitizing here and would … #1098

wants to merge 1 commit into from

Commits on Mar 7, 2017

  1. To be honest I disagree with the way we do sanitizing here and would … 

    …even remove it as graphite supports many special characters and it depends on the developer to choose better naming conventions to his/her metrics .. when I upgraded the library to use the new version all our dashboards at work didn't work as it uses '.' in metric names which in this case has been converted to '-' developers should be able to track metrics in the following formats (e.g., search.total, search.error, search.done) and as soon as these characters are fine with graphite then why would we need to strip them or normalize them?! .. I just added some of the special characters that I'm sure are accepted by graphite and I think we should support whatever graphite supports to be backward compatible .. especially when users upgrade to the new version
    @Se7soz
    Se7soz committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    a0d390d View commit details
    Browse the repository at this point in the history