Adding a custom separator for the CsvReporter #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
approved these changes
Sep 15, 2017
| @@ -220,7 +239,10 @@ private void reportTimer(long timestamp, String name, Timer timer) { | |||
| report(timestamp, | |||
| name, | |||
| "count,max,mean,min,stddev,p50,p75,p95,p98,p99,p999,mean_rate,m1_rate,m5_rate,m15_rate,rate_unit,duration_unit", | |||
| "%d,%f,%f,%f,%f,%f,%f,%f,%f,%f,%f,%f,%f,%f,%f,calls/%s,%s", | |||
| "%d" + separator + "%f" + separator + "%f" + separator + "%f" + separator + "%f" + separator + "%f" + | |||
There was a problem hiding this comment.
What do you think about using String.join to avoid repetition? This method uses a StringBuilder under the hood, so it should provide similar performance as concatenation.
mveitas
commented
Sep 15, 2017
| this.clock = clock; | ||
| this.csvFileProvider = csvFileProvider; | ||
|
|
||
| this.histogramFormat = String.join(separator, "%d","%d","%f","%d","%f","%f","%f","%f","%f","%f","%f"); |
There was a problem hiding this comment.
While it was nice to have the headers and the format right next to each other in the code, there isn't a need to construct the same value over and for each call to report
|
Thank you for the fixing the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174