Make polling reporters testable and use the same approach when testing them #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
them. Applies to: - CsvReporter and ConsoleReporter (metrics-core) - GangliaReporter (metrics-ganglia) - GraphiteReporter (metrics-graphite) Besides the refactorings done to be able to test the reporters this change also makes metrics-core build a test-jar so that other modules can include that as a test dependency (see for example metrics-graphite/pom.xml) in addition to them having a regular compile dependency on metrics-core. This change allows the modules to access the test classes in metrics-core and hence we're able to use the same abstract base class (AbstractPollingReporterTest) for all polling reporter tests.
codahale
added a commit
that referenced
this pull request
Nov 22, 2011
Make polling reporters testable and use the same approach when testing them
|
Glorious. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to:
Besides the refactorings done to be able to test the reporters this
change also makes metrics-core build a test-jar so that other modules
can include that as a test dependency (see for example
metrics-graphite/pom.xml) in addition to them having a regular compile
dependency on metrics-core. This change allows the modules to access the
test classes in metrics-core and hence we're able to use the same
abstract base class (AbstractPollingReporterTest) for all polling reporter tests.