Adds a module for instrumentation of Jdbi 3 #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
metrics-jdbi3
branch
2 times, most recently
from
a110cf2
to
2a554f0
Compare
arteam
changed the title
arteam
force-pushed
the
metrics-jdbi3
branch
from
2a554f0
to
5f1acd0
Compare
jplock
reviewed
Dec 12, 2017
| @Override | ||
| public String getStatementName(StatementContext statementContext) { | ||
| final String rawSql = statementContext.getRawSql(); | ||
| if (rawSql == null || rawSql.length() == 0) { |
jplock
approved these changes
Dec 12, 2017
Jdbi3 has been released a couple weeks ago (https://groups.google.com/forum/#!topic/jdbi/zS4p0p83sOM) and they use a new model for instrumentation. This change adds support for setting strategies for instrumenting Jdbi apps. Implementation-wise this is a port of the `metrics-jdbi` module, improved, upgraded to Java8, and with added support for the `@Timed` annotation (previously it was not possible to set a custom metric name for an SqlObject class and method).
arteam
force-pushed
the
metrics-jdbi3
branch
from
5f1acd0
to
dbdd9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jdbi3 has been released a couple weeks ago (https://groups.google.com/forum/#!topic/jdbi/zS4p0p83sOM) and they use a new model for instrumentation. This change adds support for setting strategies for instrumenting Jdbi apps.
Implementation-wise this is a port of the
metrics-jdbimodule, improved, upgraded to Java8, and with added support for the@Timedannotation (previously it was not possible to set a custom metric name for an SqlObject class and method).