Throw on existing healt check name, fixes #1245 #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xisting name. This fixes dropwizard#1245.
arteam
approved these changes
Jan 4, 2018
| if (registered != null) { | ||
| if (registered == null) { | ||
| throw new IllegalArgumentException("A health check named " + name + " already exists"); | ||
| } else { |
There was a problem hiding this comment.
It seems to me that it would be better to move throwing exception near to the containsKey check. It looks more logical (we check that the health check doesn't exist, otherwise throw an exception).
if (!healthChecks.containsKey(name)) {
....
} else {
throw new IllegalArgumentException("A health check named " + name + " already exists");
}Also this allows to remove the not null check before invoking the listeners, since the compiler will guarantee that registered will be always not null.
|
Thank you for the contribution! |
|
Thanks for merging so quickly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an exception when registering a health check under an already existing name. This fixes #1245.