HealthCheck as an interface #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The biggest setback for turning Nevertheless, it seems reasonable to implement this change in Metrics 5.0 along with other breaking changes. |
|
Makes sense. Do you want me to create a PR against the |
|
Yes, please. That would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been longing for
HealthCheckto be an interface for some time and had som recent code that'd been better of if it were so decided to take a stab at it. If for nothing else to allow easier assessment of the impact of such a change.(wasn't able to run all tests locally due to networking weirdnesses, partly addressed in #1282, but hey it complies 馃槵)
Closes #697
Partly addresses #846