Add JDK9 module name for metrics-logback #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
added a commit
that referenced
this pull request
Dec 27, 2018
sleberknight
pushed a commit
to sleberknight/metrics
that referenced
this pull request
Dec 28, 2018
arteam
pushed a commit
that referenced
this pull request
Dec 30, 2018
* Add JDK9 module name for metrics-logback (#1368) * Add ability to provide a custom Clock to health check ResultBuilder - Add Clock argument to private HealthCheck.Result constructors - Use Clock.defaultClock() as the default clock in HealthCheck.Result - Use the Clock instance to obtain the current time for the timestamp in HealthCheck.Result private constructor - Add a Clock to HealthCheck.ResultBuilder with Clock.defaultClock() as the default value - Add usingClock(Clock) to HealthCheck.ResultBuilder to allow customizing the Clock when using the builder to create health check Results - Add test of ResultBuilder#usingClock in HealthCheckTest - Update toString test in HealthCheckTest making use of ResultBuilder#usingClock so that the timestamp can be included in the equality check - Add a new test of the ResultBuilder#withMessage(String, Object...) method in HealthCheckTest (because IntelliJ flagged it as not used) - Update HealthCheckServletTest to use ResultBuilder#usingClock so that the assertions can include the timestamp and check the entire response content of the health check In both HealthCheckTest and HealthCheckServletTest I duplicated the date/time pattern from HealthCheck.Result, which is not ideal, but is better than exposing the Result's private Pattern. Unless the pattern is also made configurable, this seemed like a decent trade-off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.