A first stab at Eclipse support #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd recommend checking out sbt-eclipsify instead of baking the Eclipse files into the project. Feel free to reopen with sbt-eclipsify support, though! |
|
Uhm, did you read the diff? ;) This pull request is adding sbt-eclipsify support, it's not baking the Eclipse files into the project - even though I can see that my issue description might have given that impression. |
|
Ah, sorry -- that's what I get for trying to go through pull requests on my phone. |
|
I rebased it, resolved the conflict, and applied the patch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm way too new to Scala, SBT and their possible integration with Maven and/or Eclipse to be certain that this is the way to go about Eclipse support or that it's even a good idea. It does however generate project files and doesn't seem to cause any trouble. Apply or discard at as you see fit.