Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name control #5

Closed
wants to merge 9 commits into from
Closed

Conversation

moonpolysoft
Copy link

Allows users to control the naming of the domain and type when using jmx metrics. Values can be overridden like so:

class Blah extends Instrumented {
  override protected lazy val metricsGroup = 
    new MetricsGroup(NameBuilder("custom.domain", "CustomType"))
}

Cliff Moon and others added 9 commits July 15, 2010 16:37
Conflicts:
	project/build.properties
	project/build/Metrics.scala
Conflicts:
	project/build/Metrics.scala
	src/main/scala/com/yammer/jmx/JmxManaged.scala
…merely override metricsGroup while inheriting Instrumented to use custom values.
@moonpolysoft
Copy link
Author

Put back the original method signatures on Metrics.java to avoid breakage of deployed code.

@ghost ghost assigned codahale Apr 15, 2011
@codahale
Copy link
Contributor

codahale commented May 4, 2011

Got this covered in 2.0.0-BETA11-SNAPSHOT after the feature/scoped-names merge.

@codahale codahale closed this May 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants