Upgrade to Jetty 9.2.0

[joschi]

Jetty 9.1.x and higher introduce some nice features like support for Servlet API 3.1 and Websockets. This PR adds support for Jetty 9.2.0 to Metrics.

[ryantenney]

If I'm not mistaken, this makes it compatible with both Jetty 9.0 and 9.1?

[joschi]

It should at least compile with Jetty 9.0 and 9.1 but there have been some changes in the HttpChannelState.State (9.0.7.v20131107 vs. 9.1.0.v20131115) which will probably lead to some wrong metrics (e. g. HttpChannelState.State.REDISPATCHED should be accounted for in Jetty 9.0).

The alternative to upgrading metrics-jetty9 is creating a separate module for Jetty 9.1 which is almost identical except for the (transitive) dependencies.

[joschi]

Reading issue #521 it probably makes most sense to introduce an additional module metrics-jetty91 for supporting Jetty 9.1, even if that means having to maintain some duplicate code.

[joschi]

I've reorganized the PR.

The original module metrics-jetty9 (compatible with Jetty 9.0) has been renamed to metrics-jetty9-legacy and the new module is called metrics-jetty9 (compatible with Jetty 9.1 and higher).

[cemo]

@ryantenney This will be another big step after Jersey 2 support. Any chance to be merged?

[ryantenney]

Things have been a bit hectic so I hadn't had a chance to review this. Thanks @joschi!

[paskos]

I'm using jetty 9.2.0.v20140526 and metrics-jetty9 version 3.0.2
I get
java.lang.NoSuchMethodError: org.eclipse.jetty.server.HttpChannelState.isDispatched()Z
at com.codahale.metrics.jetty9.InstrumentedHandler$1.onComplete(InstrumentedHandler.java:142)

Do you have a timeline for the fix or a patch I can implement ?

[ryantenney]

This is the patch you're looking for. I expect to release it as 3.1.0 in July.

[paskos]

Thanks, any advice on how to mitigate while I wait for july's release ?

[paskos]

Sorry I didn't read the code. I'll gasp copy/paste the changes into a class in my project and I'll delete ir in july.

[ryantenney]

Assuming you're using maven, I'd advise cloning the git repository, mvn install it into your local maven repo and change your project's dependency on all metrics modules to version 3.1.0-SNAPSHOT.