Allow specifying a default reservoir for a registry. #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A usage pattern for the metrics library is to create a MetricRegistry and use the counter(), histogram(), meter() and timer() methods to create metrics for the application. When these methods are called MetricRegistry potentially creates new metrics with their default parameters. Creating metrics with non-default parameters, in particular a non-default reservoir, currently requires explicitly creating the metric and then registering it and remembering it for future use. This prevents leveraging functionality already provided by MetricsRegistry. Proposed approach: Allow specifying a ReservoirBuilder at MetricsRegistry creation time. ReservoirBuilder creates new reservoirs with custom parameters. This allows the creation of histograms and timers with custom default reservoirs. Alternate approaches: A potentially more comprehensive approach would be to allow passing a custom "MetricsBuilder" to the MetricsRegistry constructor. This approach is definitely worth exploring. Closes #679
|
Thanks! This may have to wait for v4, as I don't anticipate a 3.2 release. |
|
This will be supported by v4, but the API for it will look different from this. |
|
The original idea was really good, is this on the roadmap? |
|
any plans to release these changes? |
|
It's up to the maintainers. Not sure if anything similar got included in 4.x. (Chasing gophers on k8s nowadays) |
|
@ryantenney Checked the latest implementation MetricsRegistry certainly does not align with what you suggested, meaning no customize for reservoir in MetricsRegistry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A usage pattern for the metrics library is to create a MetricRegistry
and use the counter(), histogram(), meter() and timer() methods to
create metrics for the application. When these methods are called
MetricRegistry potentially creates new metrics with their default
parameters.
Creating metrics with non-default parameters, in particular a
non-default reservoir, currently requires explicitly creating the
metric and then registering it and remembering it for future use.
This prevents leveraging functionality already provided by
MetricsRegistry.
Proposed approach:
Allow specifying a ReservoirBuilder at MetricsRegistry creation
time. ReservoirBuilder creates new reservoirs with custom
parameters. This allows the creation of histograms and timers
with custom default reservoirs.
Alternate approaches:
A potentially more comprehensive approach would be to allow
passing a custom "MetricsBuilder" to the MetricsRegistry
constructor. This approach is definitely worth exploring.
Closes #679