-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a module to write metrics to InfluxDb #815
Adding a module to write metrics to InfluxDb #815
Conversation
@ryantenney I know you are reluctant for new modules but InfluxDb usage is greatly increased. Adding support for InfluxDB would be nice. 👍 |
Given the newfound focus in v4 on tagged metrics, I will be accepting new reporters for backends which support tags. |
@ryantenney That's great to know. This metrics-influxdb module also supports tags. |
Adding a module to write metrics to InfluxDb
@leelasharma merged, thanks! |
@ryantenney @cemo Actually no real reason, thanks for pointing out. I just submitted a pull request to use the same jackson libraries as the project. |
*/ | ||
public InfluxDbHttpSender(final String hostname, final int port, final String database, final String authString, | ||
final TimeUnit timePrecision) throws Exception { | ||
this.url = new URL("http", hostname, port, "/write"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should either add a flag to support HTTPS or we should offer a constructor allowing to pass in the full URL.
Agreed. I am planning on rewriting this to use the Apache http client. I'll make certain it supports https. |
In general HTTPS support makes perfect sense, but InfluxDB 0.9 does currently not support HTTPS. There is an open ticket and it looks like it will be included in the next minor release (0.9.2). For the rewrite it could make sense to have a look at the official InfluxDB Java client too. Seems that they are close to releasing a new version that supports the new InfluxDB 0.9 API. |
I'd suggest also looking at line protocol versus json as it's the preferred method and not deprecated like JSON is. With line protocol there are some performance notes to remember, like sorting tags & escaping certain chars. |
So what's the status on this feature? Is anyone working on it? |
https://github.com/davidB/metrics-influxdb and https://github.com/iZettle/dropwizard-metrics-influxdb are the most up to date InfluxDB reporters for Metrics 3.2. Unfortunately, for the 4.0 version there is no active maintained reporter under the |
Okay thanks for the update! |
Adding metrics-influxdb module to enable writing application metrics to influxdb.
The latest v0.9 influxdb release was announced recently and it will be great to have metrics report to influxdb as well, similar to graphite.