Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a module to write metrics to InfluxDb #815

Merged
merged 1 commit into from
Jun 20, 2015
Merged

Adding a module to write metrics to InfluxDb #815

merged 1 commit into from
Jun 20, 2015

Conversation

leelasharma
Copy link

Adding metrics-influxdb module to enable writing application metrics to influxdb.
The latest v0.9 influxdb release was announced recently and it will be great to have metrics report to influxdb as well, similar to graphite.

@cemo
Copy link

cemo commented Jun 17, 2015

@ryantenney I know you are reluctant for new modules but InfluxDb usage is greatly increased. Adding support for InfluxDB would be nice.

👍

@ryantenney
Copy link
Contributor

Given the newfound focus in v4 on tagged metrics, I will be accepting new reporters for backends which support tags.

@leelasharma
Copy link
Author

@ryantenney That's great to know. This metrics-influxdb module also supports tags.

ryantenney added a commit that referenced this pull request Jun 20, 2015
Adding a module to write metrics to InfluxDb
@ryantenney ryantenney merged commit e847f50 into dropwizard:master Jun 20, 2015
@ryantenney
Copy link
Contributor

@leelasharma merged, thanks!

@leelasharma
Copy link
Author

@ryantenney @cemo Actually no real reason, thanks for pointing out. I just submitted a pull request to use the same jackson libraries as the project.

*/
public InfluxDbHttpSender(final String hostname, final int port, final String database, final String authString,
final TimeUnit timePrecision) throws Exception {
this.url = new URL("http", hostname, port, "/write");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either add a flag to support HTTPS or we should offer a constructor allowing to pass in the full URL.

@ryantenney
Copy link
Contributor

Agreed. I am planning on rewriting this to use the Apache http client. I'll make certain it supports https.

@mnuessler
Copy link

In general HTTPS support makes perfect sense, but InfluxDB 0.9 does currently not support HTTPS. There is an open ticket and it looks like it will be included in the next minor release (0.9.2).

For the rewrite it could make sense to have a look at the official InfluxDB Java client too. Seems that they are close to releasing a new version that supports the new InfluxDB 0.9 API.

@jhorwit2
Copy link

I'd suggest also looking at line protocol versus json as it's the preferred method and not deprecated like JSON is. With line protocol there are some performance notes to remember, like sorting tags & escaping certain chars.

@mnp
Copy link

mnp commented Jul 11, 2017

So what's the status on this feature? Is anyone working on it?

@arteam
Copy link
Member

arteam commented Jul 11, 2017

https://github.com/davidB/metrics-influxdb and https://github.com/iZettle/dropwizard-metrics-influxdb are the most up to date InfluxDB reporters for Metrics 3.2. Unfortunately, for the 4.0 version there is no active maintained reporter under the io.dropwizard.metrics package.

@mnp
Copy link

mnp commented Jul 11, 2017

Okay thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants