Slightly better random generation for reservoir sampling #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codahale
added a commit
that referenced
this pull request
Oct 24, 2011
Slightly better random generation for reservoir sampling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextLong() % nIs ever so slightly not uniform since2^63is generally not a multiple ofn. Truthfully you would need 10+ million calls to even get a tiny change of seeingnextLong()return a number in "unfair range" (i.e. aboveLong.MAX_VALUE-Long.MAX_VALUE%n), but even if it doesn't happen the only cost is the extra function call