Optimizing unit tests #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
requested changes
Jan 5, 2017
There was a problem hiding this comment.
@Husseincoder, thanks for your desire to contribute! The change looks good, I've added one comment which need to be addressed.
| input.close(); | ||
| } | ||
| return builder.toString(); | ||
| return new String(Files.readAllBytes(new File(dataDirectory, filename).toPath())); |
|
|
||
| public class DerivativeGaugeTest { | ||
| private final Gauge<String> gauge1 = new Gauge<String>() { |
There was a problem hiding this comment.
I don't think there is a big improvement in replacing a simple gauge with a mock object. I would avoid mocking unless needed. Could you please revert this change?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to contribute to this repo and I have already used it at work to monitor our backend application .. so I've decided to start looking at the unit tests to understand more about how the whole lib work and found some optimizations that could be added to some of the unit tests