README: Update and add tips about usage in Docker and CI #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harriha
commented
Feb 20, 2020
| building in Docker, you might need to adjust configuration in `.npmrc`. See | ||
| [#185](https://github.com/ds300/patch-package/issues/185). | ||
| - In your `Dockerfile`, remember to copy over the patch files *before* running | ||
| `[npm|yarn] install` |
There was a problem hiding this comment.
To clarify: this is pretty obvious once you realize it, but in addition to myself, others have apparently tripped over this as well, so thought that perhaps worth a mention.
|
Doesn't seem to work for me in 2024. Can you share your Dockerfile in full please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some trouble in my Docker-based setup also on Travis, thus came up with some suggestions. Feel free to modify if need be.
The note referring to #185 wasn't about Gitlab specifically, ran into the same issue on local Docker builds as well as on Docker @ Travis, thus generalized that note a bit.