-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement daily schedule sp #28
Conversation
"github.com/datagovsg/nomad-parametric-autoscaler/resources" | ||
) | ||
|
||
func TestDecodingDailyScheduleSP(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: can include tests for invalid body should return error, valid body but invalid params should return error
}, nil | ||
} | ||
|
||
func verifyDailyScheduleMetadata(meta DailyScheduleSubPolicyMetadata) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too bad mapstructure
doesn't support the struct tag binding:"Required"
like in Gin, otherwise this wouldnt be necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New sp allows user to set minimum levels throughout the day.
Daily Schedule's metadata schema.