Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning before deletion of resource or sp #30

Merged
merged 5 commits into from
Jul 30, 2019
Merged

Add warning before deletion of resource or sp #30

merged 5 commits into from
Jul 30, 2019

Conversation

slai11
Copy link
Contributor

@slai11 slai11 commented Jul 29, 2019

Based on suggestion from @xtrntr, I've added a dialog that warns the user against deletion of subpolicies and resources.

guangie88
guangie88 approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@guangie88 guangie88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with trivial comments

@slai11 slai11 changed the base branch from flowtyping to master July 30, 2019 10:19
@slai11 slai11 merged commit c016bb1 into master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangie88 guangie88 guangie88 approved these changes

@brandonyeoxg brandonyeoxg Awaiting requested review from brandonyeoxg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slai11 @guangie88