Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gateways without public IPs on AWS #1224

Merged
merged 1 commit into from
May 15, 2024

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented May 15, 2024

Closes #1171

This PR adds support for gateways without public IPs on AWS that can run services with https: false. The support for private gateways that can services with https: true is to be addressed in a separate issue.

The PR also:

  • Makes AWS backend respect VPC configuration when creating gateway (default vpc/subnet was always used before).
  • Fixes a bug introduced in Implement dstack apply for gateways #1223 (wrong gateway ssh key passed).

An example of a gateway without public IP configuration:

type: gateway
name: test-private-gateway
backend: aws
region: eu-central-1
domain: '*.example.com'
public_ip: false
default: True

@r4victor r4victor merged commit 3f1504b into master May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support internal-facing gateways on AWS
1 participant