Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPU service and task example #1416

Closed
wants to merge 32 commits into from
Closed

Conversation

Bihan
Copy link
Collaborator

@Bihan Bihan commented Jul 17, 2024

No description provided.

@peterschmidt85
Copy link
Contributor

What about a README file? Do you have an idea of what could be written there?

@Bihan
Copy link
Collaborator Author

Bihan commented Jul 18, 2024

What about a README file? Do you have an idea of what could be written there?

@peterschmidt85 Do you mean this README file?

@peterschmidt85
Copy link
Contributor

@Bihan I mean typically every example we have has a README.md like https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/axolotl/README.md (a detailed one)or https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/qlora/README.md (a short one - didn't have time to write a good one).

@Bihan
Copy link
Collaborator Author

Bihan commented Jul 18, 2024

@Bihan I mean typically every example we have has a README.md like https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/axolotl/README.md (a detailed one)or https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/qlora/README.md (a short one - didn't have time to write a good one).

@peterschmidt85 I had added a README.md here for the TPU/TGI example. I will add more details in this README file.

@peterschmidt85
Copy link
Contributor

@Bihan I mean typically every example we have has a README.md like https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/axolotl/README.md (a detailed one)or https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/qlora/README.md (a short one - didn't have time to write a good one).

@peterschmidt85 I had added a README.md here for the TPU/TGI example. I will add more details in this README file.

Oh, I missed it when reviewed it. If you want to add more details what can we add that could be very useful?

@Bihan
Copy link
Collaborator Author

Bihan commented Jul 18, 2024

@Bihan I mean typically every example we have has a README.md like https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/axolotl/README.md (a detailed one)or https://github.com/dstackai/dstack/blob/master/examples/fine-tuning/qlora/README.md (a short one - didn't have time to write a good one).

@peterschmidt85 I had added a README.md here for the TPU/TGI example. I will add more details in this README file.

Oh, I missed it when reviewed it. If you want to add more details what can we add that could be very useful?

@peterschmidt85 We can add about the image huggingface/optimum-tpu:latest. Also point to optimum-tpu repo for more details. Mention the models (Gemma (2b, 7b), Llama2 (7b) and Llama3 (8b)) supported by it. Finally, we can mention that all TPU Cores are utilized in Inference.

@peterschmidt85
Copy link
Contributor

peterschmidt85 commented Jul 18, 2024 via email

[Optimum TPU :material-arrow-top-right-thin:{ .external }](https://github.com/huggingface/optimum-tpu){:target="_blank"}.
Llama 3.1 8B using
[Optimum TPU :material-arrow-top-right-thin:{ .external }](https://github.com/huggingface/optimum-tpu){:target="_blank"}
and [vLLM :material-arrow-top-right-thin:{ .external }](https://github.com/huggingface/optimum-tpu){:target="_blank"}.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed vLLM link is wrong. I will update it.

@Bihan
Copy link
Collaborator Author

Bihan commented Sep 5, 2024

Closing PR Due to Squashing Complexity and for Repo Cleanliness

This PR is being closed to address issues with squashing commits and maintaining a clean commit history. New PR is opened with the appropriate changes consolidated into a single, clean commit.

@Bihan Bihan closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants