Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RSA, ECDSA, ed25519 keys(#1443) #1641

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

swsvc
Copy link
Contributor

@swsvc swsvc commented Aug 29, 2024

DSA/DSS key type requires password when connecting via standard ssh client. Solution will require more code to write, so it is not implemented right now

@swsvc swsvc force-pushed the 1443-support-other-key-types branch from d4278cf to 4e4957d Compare August 29, 2024 12:55
@swsvc swsvc changed the title Support RSA, ECDSA, ed25519 keys Support RSA, ECDSA, ed25519 keys(#1443) Aug 29, 2024
Copy link
Collaborator

@un-def un-def left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

DSA/DSS [...] not implemented right now

I think this is not a problem at all, DSA keys have a bad reputation and will be finally removed from OpenSSH in less than six months.

@un-def un-def merged commit fd8cdf1 into dstackai:master Aug 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants