Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GIT_SSH_COMMAND and ssh-keygen on Windows #1686

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

un-def
Copy link
Collaborator

@un-def un-def commented Sep 13, 2024

  • Normalize identity path in GIT_SSH_COMMAND
  • Add ssh utils discovery, use it for ssh-keygen
  • Move find_ssh_client() to utils/ssh
  • Change ssh client discovery order -- check for ssh in PATH before well-known OpenSSH_for_Windows location (since we don't support it)

Fixes: #1680

* Normalize identity path in GIT_SSH_COMMAND
* Add ssh utils discovery, use it for ssh-keygen
* Move find_ssh_client() to ssh/utils
* Change ssh client discovery order -- check for ssh in PATH before
  well-known OpenSSH_for_Windows location (since we don't support it)

Fixes: #1680
@un-def un-def merged commit 1331a02 into master Sep 16, 2024
23 checks passed
@un-def un-def deleted the issue_1680_fix_git_ssh_command_on_windows branch September 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dstack init --git-identity doesn't accept backslashes in path on Windows
2 participants