Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runner] fix MonotonicTimestamp #1728

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[runner] fix MonotonicTimestamp #1728

merged 1 commit into from
Sep 26, 2024

Conversation

un-def
Copy link
Collaborator

@un-def un-def commented Sep 25, 2024

  • make it monotonic
  • don't allow counter overflow — in a worst-case scenario it will repeat the same timestamp with 999 milliseconds, which is still better than out-of-order timestamps

Fixes: #1727

@un-def
[runner] fix MonotonicTimestamp
ea40f82 
* make it monotonic
* don't allow counter overflow — in a worst-case scenario it will repeat
  the same timestamp with 999 milliseconds, which is still better than
  out-of-order timestamps

Fixes: #1727
@un-def un-def merged commit 4392ff6 into master Sep 26, 2024
23 checks passed
@un-def un-def deleted the issue_1727_runner_fix_monotonic_timestamp branch September 26, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4victor r4victor r4victor approved these changes

@jvstme jvstme Awaiting requested review from jvstme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [runner] MonotonicTimestamp may produce out-of-order timestamps
2 participants
@un-def @r4victor