Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the build exists before starting an instance #534

Merged
merged 13 commits into from
Jul 5, 2023

Conversation

Egor-S
Copy link
Contributor

@Egor-S Egor-S commented Jun 30, 2023

Closes #522
Fixes #538

  • Implement Storage interface for Local backend
  • Change the naming scheme of build diffs
    • Hub could check build existence before running the job
  • Hub checks a build existence on get_plan and run_job
  • Print diff size before downloading
  • Show the build plan in the run plan table (yes, no, use)

@Egor-S Egor-S merged commit 021389b into master Jul 5, 2023
30 checks passed
@Egor-S Egor-S deleted the issue_522_check_build_exists branch July 5, 2023 09:26
peterschmidt85 pushed a commit that referenced this pull request Jul 5, 2023
* Check if build exists before running instance

* Fixes after rebase

* Remove unnecessary run status check

* Check build's head file on getting plan and running job

* Implement Storage interface for Local backend. Use build heads

* Fix merge mistake

* Add tests for LocalStorage.List

* Adjust build messages

* Add traces to PutBuildDiff

* Use repo_id for the build diff prefix

* Show build plan in the table

* Install ipykernel both in build and run time
peterschmidt85 added a commit that referenced this pull request Jul 5, 2023
…he CUDA image (#541)

* - [Docker] Pre-configure the `nvidia/label/cuda-11.4.3` channel for `conda` in the CUDA image
- [Docker] Enable `always_yes` for `conda`
- [Docker] Run `conda clean` at the end

* Check if the build exists before starting an instance (#534)

* Check if build exists before running instance

* Fixes after rebase

* Remove unnecessary run status check

* Check build's head file on getting plan and running job

* Implement Storage interface for Local backend. Use build heads

* Fix merge mistake

* Add tests for LocalStorage.List

* Adjust build messages

* Add traces to PutBuildDiff

* Use repo_id for the build diff prefix

* Show build plan in the table

* Install ipykernel both in build and run time

---------

Co-authored-by: Egor Sklyarov <egor.sklyarov.ru@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant