Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor providers, add custom docker images support #544

Merged
merged 26 commits into from
Jul 11, 2023
Merged

Refactor providers, add custom docker images support #544

merged 26 commits into from
Jul 11, 2023

Conversation

Egor-S
Copy link
Contributor

@Egor-S Egor-S commented Jul 7, 2023 •
edited
Loading

Closes #540
Closes #550

  • Replace providers with job configurators
  • Validate and parse configurations and profiles with pydantic models
  • Allow to configure custom docker image

TODO

  • Remove providers completely
  • Add entry point to a configuration
  • Validate custom docker images environment on the start (sshd, pip)
  • Test & debug edge cases
  • Handle validation errors
  • Print help for loaded configuration
  • Generate JSON schemas from pydantic models
  • Update docs/reference

Egor-S added 26 commits July 7, 2023 16:42
@Egor-S
Fix method return type hints
9b13e28
@Egor-S
Implement configuration pydantic models
5a32b99
@Egor-S
Outline configurator interface
7bb4864
@Egor-S
Implement configurators
6f174e2
@Egor-S
Implement run command with configurators
28c2845
@Egor-S
Drop legacy configurations loader
d6c8abd
@Egor-S
Print relevant help for dstack run
cbaf84f
@Egor-S
Handle pydantic validation errors
139e0ea
@Egor-S
Allow configuring entrypoint and home dir. Fail if sshd is missing in…
a08aa68 
… dev environment
@Egor-S
Reimplement vscode extension
87b8730
@Egor-S
Add ssh support to tasks configuration
70175ea
@Egor-S
Replace literals with enums
8bc8141
@Egor-S
Pin pydantic v1
e2ea26f
@Egor-S
Make pydantic version flexible
da99c0a
@Egor-S
Fix entrypoint tests
e9e0dfb
@Egor-S
Move ports.py
6286009
@Egor-S
Test configurators instead of providers
b55066d
@Egor-S
Drop providers
237d4af
@Egor-S
Drop json schemas
0fb3907
@Egor-S
Clean up utils.common
9383415
@Egor-S
Annotate configuration models
9ff4103
@Egor-S
Generate json schema on build
3d7cd16
@Egor-S
Generate json schema on release
204606a
@Egor-S
Update run & configuration docs
4a64574
@Egor-S
Support env variables as a list
32b9125
@Egor-S
Explicit build policy args
2ee8638
@Egor-S Egor-S merged commit d30d21f into master Jul 11, 2023
@Egor-S Egor-S deleted the issue_540_docker branch July 11, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Egor-S