Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ports to dstack run #573

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add --ports to dstack run #573

merged 2 commits into from
Jul 18, 2023

Conversation

Egor-S
Copy link
Contributor

@Egor-S Egor-S commented Jul 18, 2023

Closes #569

  • Add --ports to JobConfigurator.get_parser
  • Merge ports from args and configuration file
  • Match docker's port mapping syntax: LOCAL_PORT:CONTAINER_PORT
  • Support 8080, :8080, and 7777:8080 for CONTAINER_PORT=8080
  • Mention --ports in docs

@Egor-S Egor-S merged commit e8137f6 into master Jul 18, 2023
31 checks passed
@Egor-S Egor-S deleted the issue_569_cli_ports branch July 18, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: specify ports mapping via CLI
1 participant