fix scanner debugging #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakyShane
force-pushed
the
07-21-fix_scanner_debugging
branch
from
9342773
to
951e55e
Compare
added 3 commits
July 21, 2024 10:31
GioSensation
approved these changes
Jul 22, 2024
Comment on lines
+23
to
+25
| populateDataIfNeeded: () => { | ||
| // console.log('populateDataIfNeeded'); | ||
| }, |
There was a problem hiding this comment.
Should this still be here?
Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
dbajpeyi
reviewed
Jul 23, 2024
|
|
||
| ```bash | ||
| npm run server |
There was a problem hiding this comment.
Suggested change
| npm run server | |
| npm run serve |
|
This is waiting for another bit of work by Shane to re-enable dumping html forms in the scanner debug file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation @dbajpeyi
Asana: https://app.asana.com/0/1198964220583541/1207861029205748/f
Description
The scanner debugging flow was broken with recent changes, this fixes it + makes it more dynamic.
The most important aspect, is ensuring the entire scanning flow can execute from plain ESM module imports - by having that goal you get great debugging.
ScreenFlow.mp4