-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scanner debugging #611
base: main
Are you sure you want to change the base?
Conversation
9342773
to
951e55e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! ❤️ Just a couple of minor minor nits.
populateDataIfNeeded: () => { | ||
// console.log('populateDataIfNeeded'); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this still be here?
Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
|
||
```bash | ||
npm run server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run server | |
npm run serve |
This is waiting for another bit of work by Shane to re-enable dumping html forms in the scanner debug file. |
Reviewer: @GioSensation @dbajpeyi
Asana: https://app.asana.com/0/1198964220583541/1207861029205748/f
Description
The scanner debugging flow was broken with recent changes, this fixes it + makes it more dynamic.
The most important aspect, is ensuring the entire scanning flow can execute from plain ESM module imports - by having that goal you get great debugging.
ScreenFlow.mp4