This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Do not update Sign Count if authenticator clone is detected. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicksteele @emlun Could you please review the MR, thank you! More discussion here: #92 |
|
Sorry, I cannot. I'm also an external contributor and have no authority in this project. |
|
@yaronsumel Thank you for reviewing, do you have access to merge it? |
|
@m9a nope.. i'll just merge it to my fork which I keep updated with important PRs of this project |
|
LGTM |
|
LGTM2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cloned authenticator can decrement the sign count value leading to the logic failing to detect clone in future.